[node-core-library] Fix FileSystem.isErrnoException#5213
Merged
dmichon-msft merged 2 commits intomicrosoft:mainfrom Apr 30, 2025
Merged
[node-core-library] Fix FileSystem.isErrnoException#5213dmichon-msft merged 2 commits intomicrosoft:mainfrom
dmichon-msft merged 2 commits intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
iclanton
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a gap in
FileSystem.isErrnoExceptionfor instances where the file system call was not provided with a file path, e.g.fs.readSync, which only takes a file descriptor.Details
The method was expecting the
pathproperty to always be present and be a string, but not all methods are provided with a path.How it was tested
Added unit tests.
Impacted documentation
None.